refactor: add radio and checkbox component#1476
Draft
essenmitsosse wants to merge 16 commits intonpmx-dev:mainfrom
Draft
refactor: add radio and checkbox component#1476essenmitsosse wants to merge 16 commits intonpmx-dev:mainfrom
essenmitsosse wants to merge 16 commits intonpmx-dev:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a button and checkbox component and replaces all things I could find that were
buttonbefore but should be a radio or checkbox. It doesn't touch theSettingsTogglecomponent, which is also a checkbox.The radio button also replaces the previous
TagRadioButtonFor the checkboxes I added a variant, that looks like a toggable button. For the radio buttons I didn't. I am going to leave this PR as a draft, because I am sure there is some discussion to be had.
The goal of this PR should be to move all things that should be radio/checkboxes to an abstract component. I don't think these components need to be functionally or visually perfect just now. Having only one place to maintain them should be a benefit in itself. So I think we should try not to get lost in detailed "how round should the focus be" discussions. I also think surfacing that something is a radio/checkbox in the UI by actually displaying it can be good intermediate step to make everybody think more consciously about UX dicisions. What I mean by that: 'Maybe if too many radio buttons look to crowded, the problem is not showing them, but having so many of them' — maybe.